Skip to content

Debug for CargoCmd #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

Debug for CargoCmd #415

merged 1 commit into from
Sep 29, 2025
+9 −3

Conversation

tuguzT
Copy link
Contributor

@tuguzT tuguzT commented Sep 28, 2025

Fix CargoCmd to implement Debug instead of Display (which was presumably a typo).
Also implement From<CargoCmd> for Command which will be useful a bit later (as a part of Rust-GPU/cargo-gpu#112).

@tuguzT tuguzT mentioned this pull request Sep 28, 2025
Open
LegNeato
LegNeato approved these changes Sep 29, 2025
View reviewed changes
Copy link
Collaborator

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LegNeato LegNeato added this pull request to the merge queue Sep 29, 2025
Merged via the queue into Rust-GPU:main with commit 929112a Sep 29, 2025
13 checks passed
@tuguzT tuguzT deleted the spirv-builder-cargo-cmd-debug branch September 29, 2025 08:33
@Firestar99
Copy link
Member

thanks, that one is on me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LegNeato LegNeato LegNeato approved these changes

@eddyb eddyb Awaiting requested review from eddyb eddyb is a code owner

@Firestar99 Firestar99 Awaiting requested review from Firestar99 Firestar99 is a code owner

@schell schell Awaiting requested review from schell schell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuguzT @Firestar99 @LegNeato