add vulkan indirect command structs #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
force-pushed
the
indirect_command
branch
from
27088d7 to
c676db1
Compare
Firestar99
force-pushed
the
indirect_command
branch
from
a7d9817 to
b3f8ec0
Compare
Firestar99
commented
Oct 13, 2024
|
|
||
| [features] | ||
| default = [] | ||
| bytemuck = ["dep:bytemuck", "glam/bytemuck"] |
Member
Author
There was a problem hiding this comment.
I've added bytemuck as an optional dependency to mark all the *IndirectCommand structs as Pod, as most graphics APIs will require this. Should we make the bytemuck dependency required, eg. not hidden behind a feature?
Contributor
There was a problem hiding this comment.
I think keeping bytemuck optional is good. It's true that most graphics projects will have it somewhere in the tree, but I don't think we should be deciding how folks marshal data to the GPU.
Firestar99
force-pushed
the
indirect_command
branch
from
b3f8ec0 to
6cc7f95
Compare
schell
approved these changes
Oct 13, 2024
LegNeato
approved these changes
Oct 13, 2024
Collaborator
LegNeato
left a comment
LegNeato
left a comment
There was a problem hiding this comment.
Seems reasonable to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*IndirectCommandstructs from vulkan, mostly copied them from ash.Pod