Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for cargo during libgrust configuration #2938

Closed
wants to merge 1 commit into from
Closed

Check for cargo during libgrust configuration #2938

wants to merge 1 commit into from

Conversation

P-E-P
Copy link
Member

@P-E-P P-E-P commented Apr 3, 2024 •
edited
Loading

libgrust configuration script did not check for cargo, which is now required in order to build libformat_parser.

Fixes #2881

@P-E-P
Check for cargo during libgrust configuration
c810874 
libgrust configuration script did not check for
cargo, which is now required in order to build
libformat_parser.

libgrust/ChangeLog:

	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* configure.ac: Add check for cargo, error out
	when cargo is missing.
	* libproc_macro_internal/Makefile.in: Regenerate.

Signed-off-by: Pierre-Emmanuel Patry <[email protected]>
@P-E-P P-E-P requested a review from CohenArthur April 3, 2024 11:45
@P-E-P P-E-P marked this pull request as ready for review April 3, 2024 13:45
@tschwinge
Copy link
Member

The should be done in the top-level configure.ac, similar to "Disable Ada if no preexisting GNAT is available", or "Disable D if no preexisting GDC is available".

@P-E-P
Copy link
Member Author

P-E-P commented Apr 5, 2024

The should be done in the top-level configure.ac, similar to "Disable Ada if no preexisting GNAT is available", or "Disable D if no preexisting GDC is available".

@tschwinge AFAIK we can't modify top level configure since common directories are already frozen ?

@P-E-P
Copy link
Member Author

P-E-P commented Apr 5, 2024

Close in favor of #2942

@P-E-P P-E-P closed this Apr 5, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CohenArthur CohenArthur CohenArthur approved these changes

@tschwinge tschwinge Awaiting requested review from tschwinge

@dkm dkm Awaiting requested review from dkm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add checking that cargo exists when building gccrs
3 participants
@P-E-P @tschwinge @CohenArthur