Block on #41
Merged
Block on #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Donemmanuelo
requested review from
AssahBismarkabah,
Awungia112,
Christiantyemele and
bansikah22
Awungia112
previously approved these changes
Apr 28, 2025
Collaborator
Awungia112
left a comment
Awungia112
left a comment
There was a problem hiding this comment.
Good explanation of block_on @Donemmanuelo , just a few spelling errors and shorter paragraphs would be better for easy readability.
…ctions - Replace todo!() in client.rs send_commands with full command parsing implementation - Add support for /join, /post, /help, and /quit commands - Implement handle_subscriber function in server group.rs for message broadcasting - Add comprehensive tests for command parsing functionality - Fix async-std stdin usage with proper BufReader and BufReadExt imports Resolves the 'not yet implemented' crash when running the client Both client and server now fully functional for group chat operations
Collaborator
|
@Christiantyemele , @Ngha-Boris please review |
Member
|
@chojuninengu please fix failing pipeline first |
- Run cargo fmt to fix all formatting violations - Ensure CI pipeline passes formatting checks - No functional changes, only code style improvements
Collaborator
|
Done, was a formating issue @Christiantyemele |
chojuninengu
added
enhancement
Member
Christiantyemele
left a comment
Christiantyemele
left a comment
There was a problem hiding this comment.
Good work @Donemmanuelo @chojuninengu , Fix the typos and i'll approve
- Fix grammatical errors and improve readability - Correct subject-verb agreement issues - Fix pronoun usage and punctuation - Improve sentence structure and flow - Capitalize 'Rust' properly throughout the document
Collaborator
|
@Christiantyemele , just made the changes |
Christiantyemele
approved these changes
Nov 11, 2025
chojuninengu
requested review from
Blindspot22 and
Dericko681
and removed request for
AssahBismarkabah and
bansikah22
Dericko681
approved these changes
Nov 12, 2025
Awungia112
approved these changes
Nov 12, 2025
Collaborator
|
@Christiantyemele , can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.