Process prefilled cashu link for wallet credit #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: db2002dominic <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Deploying routstr-chat with
|
| Latest commit: |
03952eb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://98a5697f.routstr-chat.pages.dev |
| Branch Preview URL: | https://cursor-process-prefilled-cas.routstr-chat.pages.dev |
kwsantiago
reviewed
Oct 20, 2025
| if (!topupFromUrl) return; | ||
| try { | ||
| localStorage.setItem('prefilled_topup_token', topupFromUrl); | ||
| } catch {} |
Contributor
There was a problem hiding this comment.
Can we log the error instead of silently catching?
| let token: string | null = null; | ||
| try { | ||
| token = localStorage.getItem('prefilled_topup_token'); | ||
| } catch {} |
Contributor
There was a problem hiding this comment.
Can we log the error instead of silently catching?
| if (!token) return; | ||
|
|
||
| processingTopupRef.current = true; | ||
| (async () => { |
Contributor
There was a problem hiding this comment.
Without awaiting here, errors may not surface properly.
| await receiveToken(token as string); | ||
| try { localStorage.removeItem('prefilled_topup_token'); } catch {} | ||
| } catch (err) { | ||
| console.error('Failed to process prefilled topup token:', err); |
Contributor
There was a problem hiding this comment.
Should provide user feedback when token processing fails, not just console.error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement automatic crediting of Cashu tokens from
?topupURL parameters to support pre-filled topup links for new and existing users (fixes #90).