Move everything to a tick loop #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grepsedawk
force-pushed
the
ticker-i-hardly-know-her
branch
from
9a1b70b
to
564a8f7
Compare
grepsedawk
changed the title
grepsedawk
force-pushed
the
ticker-i-hardly-know-her
branch
from
564a8f7
to
4f248c6
Compare
grepsedawk
requested review from
Gjum,
ArtificialDriver and
awoo-civ
and removed request for
Gjum
grepsedawk
force-pushed
the
ticker-i-hardly-know-her
branch
4 times, most recently
from
22aa285
to
aa06fe9
Compare
grepsedawk
commented
Aug 2, 2023
Comment on lines
+167
to
+173
| def using_hand_delay_for(slot) | ||
| if slot.edible? | ||
| 32 | ||
| else | ||
| 4 | ||
| end | ||
| end |
There was a problem hiding this comment.
This is not how vanilla does this code-wise, but I think it actually works in context
grepsedawk
commented
Aug 2, 2023
| @@ -46,8 +46,8 @@ class Rosegold::Block | |||
| best_tool?(slot) || harvest_tools.try &.keys.includes? slot.item_id_int.to_s | |||
| end | |||
|
|
|||
| def break_time(main_hand : Slot, player : Player, creative : Bool = false) : Int32 | |||
| return 0 if creative | |||
| def break_damage(main_hand : Slot, player : Player, creative : Bool = false) : Float64 | |||
There was a problem hiding this comment.
This change is because blocks take "damage" every tick (fraction of 1) until you get to 1.0
ArtificialDriver
approved these changes
Aug 3, 2023
grepsedawk
force-pushed
the
ticker-i-hardly-know-her
branch
from
5225b95
to
574c414
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only digging, use hand, change hotbar slot, and physics are part of this
loops sofar
Speed up the specs greatly using event emitter callbacks
Add apple to eating
Fix a ton of random anti-cheat issues
Fix a few inventory desync issues
Resolves #98
Resolves #97