[ROS1/TCPROS] Improve self-ip heuristics. #289
Draft
+82
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When neither ROS_IP nor ROS_HOSTNAME are set, use a slightly smarter heuristic to try to find an IP address in the same subnet as the rosmaster. This only works if the rosmaster is specified as an IP address, not if it is a hostname.
Carter12s
reviewed
Dec 2, 2025
| byteorder = "1.4" | ||
| thiserror = "2.0" | ||
| anyhow = "1.0" | ||
| if-addrs = "0.14.0" |
Collaborator
There was a problem hiding this comment.
get_if_addrs is explicitly a non-windows function in the if_addrs crate. Which means adding this MR explicitly makes roslibrust not support windows. While we haven't been explicitly testing for or advertising windows support, I actually do expect it to work across all our backends at the moment.
Looking around it looks like the getifs crate may be a better alternative to grab that does support windows?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When neither ROS_IP nor ROS_HOSTNAME are set, use a slightly smarter heuristic to try to find an IP address in the same subnet as the rosmaster. This only works if the rosmaster is specified as an IP address, not if it is a hostname.
closes #288
(opened as Draft so I can test it in my own system)