Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the code in node.rs into a couple separate files #146

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

ssnover
Copy link
Collaborator

@ssnover ssnover commented Dec 16, 2023

Description

Reorganize the code in node.rs into a couple separate files with different areas of concern to manage growing number of node actor methods.

As I was starting in on implementation of native Service Clients I was finding the code here growing in difficulty to navigate node.rs so I split it:

  • mod.rs is for helpers and utilities
  • actor.rs is where most of the node administration lives for the NodeServer actor
  • handle.rs is for the struct that user code uses as a handle
  • xmlrpc.rs has the former xmlrpc_server.rs module since a lot of that code was tied to code in node.rs which became clear as I was fixing use statements.

Fixes

N/A

Checklist

  • Update CHANGELOG.md

@ssnover ssnover requested a review from Carter12s December 16, 2023 20:49
…erent areas of concern to manage growing number of node actor methods
@ssnover ssnover force-pushed the reorg-native-node-module branch from be54e4e to 28df7f6 Compare December 16, 2023 22:02
@ssnover ssnover self-assigned this Jan 2, 2024
@Carter12s Carter12s merged commit 7d9a2a6 into master Jan 11, 2024
5 checks passed
@Carter12s Carter12s deleted the reorg-native-node-module branch June 29, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants