Merge pull request #140 from Carter12s/improve-test-reliability

Trying to figure out which tests are flaky and fix, adding debug info…

.github/pull_request_template.md

@@ -2,7 +2,7 @@
 `Insert description`
 
 ## Fixes
-Issue Number: `number`
+Closes: `number`
 
 ## Checklist
 - [ ] Update CHANGELOG.md

.github/workflows/galactic.yml

@@ -8,6 +8,8 @@ on:
 
 env:
   HOME: /root
+  # Coupled with our use of the test_log crate this should give us good CI output on failure
+  RUST_LOG: debug
 
 jobs:
   galactic:
@@ -22,6 +24,8 @@ jobs:
         uses: actions/checkout@v3
         with:
           submodules: 'true'
+      - name: Verify rust version
+        run: source /root/.cargo/env; rustc --version
       - name: Lint
         run: source /root/.cargo/env; cargo fmt --all -- --check
       - name: Build Main Lib

.github/workflows/humble.yml

@@ -8,6 +8,8 @@ on:
 
 env:
   HOME: /root
+  # Coupled with our use of the test_log crate this should give us good CI output on failure
+  RUST_LOG: debug
 
 jobs:
   humble:
@@ -22,6 +24,8 @@ jobs:
         uses: actions/checkout@v3
         with:
           submodules: 'true'
+      - name: Verify rust version
+        run: source /root/.cargo/env; rustc --version
       - name: Lint
         run: source /root/.cargo/env; cargo fmt --all -- --check
       - name: Build Main Lib

.github/workflows/noetic.yml

@@ -9,6 +9,8 @@ on:
 env:
   HOME: /root
   ROS_PACKAGE_PATH: /opt/ros/noetic/share
+  # Coupled with our use of the test_log crate this should give us good CI output on failure
+  RUST_LOG: debug
 
 jobs:
   noetic:
@@ -23,6 +25,8 @@ jobs:
         uses: actions/checkout@v3
         with:
           submodules: 'true'
+      - name: Verify rust version
+        run: source /root/.cargo/env; rustc --version
       - name: Lint
         run: source /root/.cargo/env; cargo fmt --all -- --check
       - name: Build Main Lib

.github/workflows/noetic_gencpp.yml

@@ -8,6 +8,8 @@ on:
 
 env:
   HOME: /root
+  # Coupled with our use of the test_log crate this should give us good CI output on failure
+  RUST_LOG: debug
 
 jobs:
   noetic_gencpp:

CHANGELOG.md

@@ -30,6 +30,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+ - Removed `find_and_generate_ros_messages_relative_to_manifest_dir!` this proc_macro was changing the current working directory of the compilation job resulting in a variety of strange compilation behaviors. Build.rs scripts are recommended for use cases requiring fine
+ grained control of message generation.
  - The function interface for top level generation functions in `roslibrust_codegen` have been changed to include the list of dependent
 filesystem paths that should trigger re-running code generation. Note: new files added to the search paths will not be automatically detected.
 

roslibrust/Cargo.toml

@@ -53,10 +53,10 @@ simple_logger = "2.1.0"
 
 [features]
 default = []
-# Provides a rosapi rust interface
-rosapi = []
 # Note: all does not include running_bridge as that is only intended for CI
 all = []
+# Provides a rosapi rust interface
+rosapi = []
 # Intended for use with tests, includes tests that rely on a locally running rosbridge
 running_bridge = []
 # For use with integration tests, indicating we are testing integration with a ros1 bridge

roslibrust/examples/native_ros1.rs

@@ -4,7 +4,7 @@
 
 #[cfg(feature = "ros1")]
 #[tokio::main]
-async fn main() -> Result<(), Box<dyn std::error::Error>> {
+async fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
     use roslibrust::NodeHandle;
 
     simple_logger::SimpleLogger::new()

roslibrust/examples/ros1_listener.rs

@@ -2,7 +2,7 @@ roslibrust_codegen_macro::find_and_generate_ros_messages!("assets/ros1_common_in
 
 #[cfg(feature = "ros1")]
 #[tokio::main]
-async fn main() -> Result<(), Box<dyn std::error::Error>> {
+async fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
     use roslibrust::NodeHandle;
 
     simple_logger::SimpleLogger::new()

roslibrust/examples/ros1_talker.rs

@@ -2,7 +2,7 @@ roslibrust_codegen_macro::find_and_generate_ros_messages!("assets/ros1_common_in
 
 #[cfg(feature = "ros1")]
 #[tokio::main]
-async fn main() -> Result<(), Box<dyn std::error::Error>> {
+async fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
     use roslibrust::NodeHandle;
 
     simple_logger::SimpleLogger::new()

roslibrust/src/ros1/master_client.rs

@@ -254,6 +254,7 @@ impl MasterClient {
                 self.client_uri.clone().into(),
             ],
         )?;
+        log::trace!("Posting {body:?} to register publisher");
         self.post(body).await
     }