Skip to content

[Fix] Fast child tasks keep orchestrator reporting after upgrades - #1957

Closed
roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/legacy-fast-report-consumer-1n7mmdvle4jrf
Closed

[Fix] Fast child tasks keep orchestrator reporting after upgrades#1957
roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/legacy-fast-report-consumer-1n7mmdvle4jrf

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

  • Restored schema-boundary normalization from the persisted legacy fast-orchestrator report consumer to the current orchestrator value.
  • Added focused coverage for legacy normalization and the existing direct-user fallback for unknown values.

Why this change was made

The original review discussion identified an upgrade compatibility gap: task-run payloads persisted before the rename can still contain fast-orchestrator. Rejecting that value makes safeParse fail and incorrectly selects the direct-user report contract for Fast-owned child tasks.

This compatibility transform must remain at the payload schema boundary until persisted legacy rows can no longer be encountered or are safely migrated.

Impact

Fast-owned child tasks resumed or settled across an upgrade retain the orchestrator reporting contract. Current canonical values are unchanged, and genuinely unknown values still fall back to direct-user.

Validation

  • pnpm exec dotenvx run -f .env.test -- pnpm --filter @roomote/cloud-agents exec vitest run src/server/workflows/__tests__/standardTaskReporting.test.ts (5 tests passed)
  • pnpm --filter @roomote/types check-types
  • pnpm --filter @roomote/cloud-agents check-types
  • Changed-file oxfmt --check and oxlint --deny-warnings
  • Full pre-push hook: oxlint, residual lint, check-types:fast, and knip

@roomote-community

roomote-community Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed b4dc0ea

@roomote-roomote

Copy link
Copy Markdown
Contributor Author

Closing this PR intentionally. We are not adding backward compatibility for legacy Fast sessions or legacy releases; the current canonical report-consumer contract will remain unchanged.

@roomote-roomote roomote-roomote Bot closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant