[Fix] Fast child tasks keep orchestrator reporting after upgrades - #1957
Closed
roomote-roomote[bot] wants to merge 1 commit into
Closed
[Fix] Fast child tasks keep orchestrator reporting after upgrades#1957roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
Contributor
Author
|
Closing this PR intentionally. We are not adding backward compatibility for legacy Fast sessions or legacy releases; the current canonical report-consumer contract will remain unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
fast-orchestratorreport consumer to the currentorchestratorvalue.direct-userfallback for unknown values.Why this change was made
The original review discussion identified an upgrade compatibility gap: task-run payloads persisted before the rename can still contain
fast-orchestrator. Rejecting that value makessafeParsefail and incorrectly selects the direct-user report contract for Fast-owned child tasks.This compatibility transform must remain at the payload schema boundary until persisted legacy rows can no longer be encountered or are safely migrated.
Impact
Fast-owned child tasks resumed or settled across an upgrade retain the orchestrator reporting contract. Current canonical values are unchanged, and genuinely unknown values still fall back to
direct-user.Validation
pnpm exec dotenvx run -f .env.test -- pnpm --filter @roomote/cloud-agents exec vitest run src/server/workflows/__tests__/standardTaskReporting.test.ts(5 tests passed)pnpm --filter @roomote/types check-typespnpm --filter @roomote/cloud-agents check-typesoxfmt --checkandoxlint --deny-warningscheck-types:fast, and knip