Skip to content

[Fix] Promotion PR metadata can reference a stale candidate - #1951

Merged
mrubens merged 1 commit into
developfrom
fix/release-candidate-sha-guard
Aug 31, 2026
Merged

[Fix] Promotion PR metadata can reference a stale candidate#1951
mrubens merged 1 commit into
developfrom
fix/release-candidate-sha-guard

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Opened on behalf of @mrubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

Promotion automation now refuses to create or edit PR metadata when an existing release/v* branch does not point at the frozen version commit. It also rechecks the remote branch, shipped state, tags, and open Promote PR after branch preparation so races fail closed.

Focused workflow assertions cover stale branch mismatches, post-push shipped-state checks, refresh PR closure, and the existing no-force policy.

Why this change was made

A historical release/v1.0.0 branch was reused while the generated PR body described a newer frozen commit, leaving the Promote PR with accurate-looking metadata but the wrong merge candidate.

Impact

Future promotion runs stop instead of presenting or refreshing a misleading release candidate. Frozen candidates still exclude later develop commits, and explicit guarded refresh remains the only automated path that moves an existing valid candidate.

Validated with all release-script tests, focused formatting and diff checks, plus the repository pre-push lint, type-check, and unused-code gates. Browser proof timed out and is not used as evidence for this workflow-only change.

Related PRs

@roomote-community

roomote-community Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 367b9ae

@mrubens
mrubens marked this pull request as ready for review August 31, 2026 20:42
@mrubens
mrubens merged commit 8308e21 into develop Aug 31, 2026
17 checks passed
@mrubens
mrubens deleted the fix/release-candidate-sha-guard branch August 31, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant