[Fix] Promotion PR metadata can reference a stale candidate - #1951
Merged
Conversation
Contributor
mrubens
marked this pull request as ready for review
August 31, 2026 20:42
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
August 31, 2026 20:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Promotion automation now refuses to create or edit PR metadata when an existing
release/v*branch does not point at the frozen version commit. It also rechecks the remote branch, shipped state, tags, and open Promote PR after branch preparation so races fail closed.Focused workflow assertions cover stale branch mismatches, post-push shipped-state checks, refresh PR closure, and the existing no-force policy.
Why this change was made
A historical
release/v1.0.0branch was reused while the generated PR body described a newer frozen commit, leaving the Promote PR with accurate-looking metadata but the wrong merge candidate.Impact
Future promotion runs stop instead of presenting or refreshing a misleading release candidate. Frozen candidates still exclude later
developcommits, and explicit guarded refresh remains the only automated path that moves an existing valid candidate.Validated with all release-script tests, focused formatting and diff checks, plus the repository pre-push lint, type-check, and unused-code gates. Browser proof timed out and is not used as evidence for this workflow-only change.
Related PRs