[Fix] View changes falls back during GitHub merge state lag - #1876
Merged
Conversation
Contributor
mrubens
marked this pull request as ready for review
August 30, 2026 05:03
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
August 30, 2026 05:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
stateandmerged_atfields still reflect their pre-merge values.Why this change was made
The staging Merge Announcer linked commit
9d606d9be068to the compare view even though it is the merge commit for PR #1766. Telemetry shows the staging API handled that webhook ondevelop-d54aa639, which already contained PR #1866, and emitted no GitHub permission or lookup error. The remaining failure was a consistency race: enrichment silently discarded the associated PR unless GitHub had already changed both lifecycle fields to their terminal values.Impact
Merge Announcer now selects the PR link during GitHub's post-merge consistency window. Direct pushes, unrelated associations, wrong-base PRs, and merge-SHA mismatches continue using the compare fallback.