New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add back deterministic streamer mode #32

Open

Kaiyotech wants to merge 1 commit into Rolv-Arild:master from Kaiyotech:add_back_deterministic_stream

Contributor

Kaiyotech commented Aug 23, 2022

No description provided.


          add back deterministic streamer mode

b7ab1fc

Owner

Rolv-Arild commented Dec 6, 2022

Is this still a missing feature?

Contributor Author

Kaiyotech commented Dec 6, 2022

Sort of. Mine is a parameter I can turn on and off, the version in main is always deterministic if streaming I think.

Owner

Rolv-Arild commented Dec 12, 2022

Actually the check is for streamer_mode > 1, so it is still an option, although definitely a bit obscure.
https://github.com/Rolv-Arild/rocket-learn/blob/master/rocket_learn/rollout_generator/redis/redis_rollout_worker.py#L385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet