Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment init #5

Merged
merged 4 commits into from
May 28, 2024
Merged

Environment init #5

merged 4 commits into from
May 28, 2024

Conversation

f-PLT
Copy link
Collaborator

@f-PLT f-PLT commented May 28, 2024

No description provided.

@f-PLT f-PLT self-assigned this May 28, 2024
@f-PLT f-PLT linked an issue May 28, 2024 that may be closed by this pull request
6 tasks
@f-PLT f-PLT added the build Core code element to be added label May 28, 2024
Copy link
Collaborator

@mjfortier mjfortier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nailed it

Copy link
Collaborator

@liellnima liellnima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me locally with conda. As tested in the meeting, works also on Mila Cluster. Additional issue will be opened for Compute Canada.

Feel free to add some empty tests with the imports if you think that would be good practice. Can be added to Compte Canada PR as well though.

@f-PLT f-PLT merged commit 8ceeb27 into main May 28, 2024
4 checks passed
@f-PLT f-PLT deleted the 4-create-an-environment branch May 28, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Core code element to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an environment
3 participants