Skip to content

Commit

Permalink
avoid bulk album query if no library albums are present
Browse files Browse the repository at this point in the history
  • Loading branch information
RocketMan committed May 27, 2024
1 parent 67ebff0 commit efe4125
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions engine/impl/Library.php
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,9 @@ public function linkReviews(&$albums, $loggedIn = false, $includeBody = false) {
}
}

if(count($tags) == 0)
return;

$ib = $includeBody?"":"null";
$query = "SELECT tag, a.airname, realname, r.id, r.created, r.private, " .
"$ib review FROM reviews r " .
Expand Down Expand Up @@ -468,6 +471,10 @@ public function markAlbumsReviewed(&$albums, $loggedIn = 0) {
$tags[$tag] = $i;
}
}

if(count($tags) == 0)
return;

$query = "SELECT tag, a.airname, realname FROM reviews r " .
"LEFT JOIN users u ON r.user = u.name " .
"LEFT JOIN airnames a ON r.airname = a.id WHERE " .
Expand Down Expand Up @@ -515,6 +522,9 @@ public function markAlbumsPlayable(&$albums) {
}
}

if(count($tags) == 0)
return;

$urlFilter = $enableExternalLinks ? "url <> ''" : "url RLIKE ?";

$query = "SELECT tag FROM tracknames ".
Expand Down

0 comments on commit efe4125

Please sign in to comment.