Skip to content

fix: back off and preserve status when remote media download fails - #410

Draft
cardoso wants to merge 1 commit into
mainfrom
fix/CORE-2617
Draft

fix: back off and preserve status when remote media download fails#410
cardoso wants to merge 1 commit into
mainfrom
fix/CORE-2617

Conversation

@cardoso

@cardoso cardoso commented Aug 27, 2026

Copy link
Copy Markdown
Member

The full fix will require a change in the Rocket.Chat repo as well (still preparing the PR).

CORE-2617

Review in cubic

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.36508% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.63%. Comparing base (d387798) to head (9e990e8).

Files with missing lines Patch % Lines
...kages/federation-sdk/src/services/media.service.ts 73.33% 8 Missing ⚠️
...ederation-sdk/src/services/staging-area.service.ts 84.84% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
+ Coverage   51.81%   52.63%   +0.81%     
==========================================
  Files         114      114              
  Lines       12704    12765      +61     
==========================================
+ Hits         6583     6719     +136     
+ Misses       6121     6046      -75     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants