test: fix flaky livechat message assertion after reload - #42055
test: fix flaky livechat message assertion after reload#42055jessicaschelly wants to merge 1 commit into
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (8)
🧰 Additional context used📓 Path-based instructions (4)Store commonly used locators in variables/constants for reuse Follow Page Object Model pattern consistently in Playwright tests📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc) Files:
All test files must be created in `apps/meteor/tests/e2e/` directory Avoid using `page.locator()` in Playwright tests - always prefer semantic locators such as `page.getByRole()`, `page.getByLabel()`, `page.getByText()`, or `page.getByTitle...📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc) Files:
Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests Avoid code comments in the implementation📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc) Files:
Use descriptive test names that clearly communicate expected behavior in Playwright tests Use `.spec.ts` extension for test files (e.g., `login.spec.ts`)📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc) Files:
🔇 Additional comments (1)
WalkthroughThe livechat end-to-end test now uses a distinct message constant after reload and verifies that exact message after sending. ChangesLivechat test update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The livechat E2E test now verifies a unique message after reload, preventing duplicate-message assertion failures. No current merge-blocking risk remains. Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Errors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #42055 +/- ##
===========================================
+ Coverage 69.31% 69.32% +0.01%
===========================================
Files 4289 4289
Lines 171486 171486
Branches 31088 31008 -80
===========================================
+ Hits 118862 118889 +27
+ Misses 47451 47429 -22
+ Partials 5173 5168 -5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
1 participant
Proposed changes (including videos or screenshots)
Stabilizes the
OC - Livechat - Send message to livechat customerE2E test after reloading the livechat widget.The serial suite sent
this_a_test_message_from_userin two consecutive tests that reused the same visitor and conversation. When both messages were rendered, Playwright's strict locator matched two elements and failed. This change gives the post-reload message unique text so the assertion can only match the newly sent message.Issue(s)
FLAKY-1414
Steps to test or reproduce
Run the affected suite five times with one worker:
Further comments
This is a test-only change and does not affect product behavior.
Summary by CodeRabbit