Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression(E2EEncryption): Encrypted quotes of files not working #32699

Open
wants to merge 4 commits into
base: release-6.10.0
Choose a base branch
from

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Jun 28, 2024

Proposed changes (including videos or screenshots)

Issue(s)

E2EE2-41

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jun 28, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 28, 2024

⚠️ No Changeset found

Latest commit: 9e6f69a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rodrigok rodrigok added this to the 6.10 milestone Jun 28, 2024
@rodrigok rodrigok changed the title Regression/fix-e2ee-quote regression(E2EEncryption): Encrypted quotes of files not working Jun 28, 2024
@rodrigok rodrigok marked this pull request as ready for review June 28, 2024 19:30
@rodrigok rodrigok requested review from a team as code owners June 28, 2024 19:30
@rodrigok rodrigok closed this Jun 28, 2024
@rodrigok rodrigok reopened this Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 75.67568% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-6.10.0@734bd76). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-6.10.0   #32699   +/-   ##
=================================================
  Coverage                  ?   56.63%           
=================================================
  Files                     ?     2494           
  Lines                     ?    55422           
  Branches                  ?    11452           
=================================================
  Hits                      ?    31389           
  Misses                    ?    21333           
  Partials                  ?     2700           
Flag Coverage Δ
e2e 56.42% <72.72%> (?)
unit 71.47% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rodrigok rodrigok marked this pull request as draft June 28, 2024 21:16
@rodrigok rodrigok marked this pull request as ready for review June 29, 2024 14:27
@milton-rucks milton-rucks added the stat: QA assured Means it has been tested and approved by a company insider label Jul 1, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants