fix(android): Improve push notification loading reliability and add diagnostic logging #6711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added detailed logging for notification loading process in LoadNotification.java. - Implemented error handling for null or empty userId and userToken. - Enhanced retry logic for network requests with clear logging of attempts and failures. - Updated Ejson.java to include logging for token and userId retrieval. - Improved fallback notification handling in CustomPushNotification.java with additional logging for failures.
diegolmello
requested a deployment
to
approve_e2e_testing
GitHub Actions
Waiting
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
diegolmello
temporarily deployed
to
experimental_android_build
GitHub Actions
Inactive
diegolmello
requested a deployment
to
experimental_ios_build
GitHub Actions
Waiting
diegolmello
requested a deployment
to
official_ios_build
GitHub Actions
Waiting
diegolmello
requested a deployment
to
official_android_build
GitHub Actions
Waiting
diegolmello
requested a deployment
to
upload_experimental_android
GitHub Actions
Waiting
|
Android Build Available Rocket.Chat Experimental 4.65.0.107532 Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNT_WZhhUi5TNV4tmGX1GR2QFqcHIvQXdxflAusqcJtIUJIV51K9uLFChkhR_6W5bnYKp535DUtnt0lmIRY_ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes critical bugs in Android push notification handling that caused "message-id-only" notifications to display placeholder text ("You have a new message") instead of loading the actual message content.
The issue was difficult to reproduce and only affected certain users. Investigation revealed multiple bugs:
This PR also adds comprehensive production-safe diagnostic logging to help identify and resolve similar issues in the future.
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-882
How to test or reproduce
Testing the fix:
message-id-onlypush notificationsVerifying logs (debug build):
adb logcat | grep RocketChatAffected screens:
Screenshots
N/A - This is a backend notification handling fix with no UI changes
Types of changes
Checklist
Further comments
Technical Details:
Bug Fixes (LoadNotification.java):
callback.call(null)ensuring proper flow continuationRETRY_COUNT <= TIMEOUT.lengthtoRETRY_COUNT < TIMEOUT.length - 1Logging (Production-Safe):
BuildConfig.DEBUG(debug builds only)Files Changed:
LoadNotification.java- Core bug fixes and error handlingCustomPushNotification.java- Added flow loggingEjson.java- Added debug-only verbose logging with BuildConfig guardsThe logging addition makes future issues like this much easier to diagnose while maintaining security and following industry standards for production logging.