Add aria2 as a recommended dependency #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For most users, `aria2` is a vast improvement to `xcodes` usage, so I think it should be added as a [recommended dependency](https://docs.brew.sh/Formula-Cookbook#specifying-other-formulae-as-dependencies) to `xcodes` when installed using Homebrew, so it'll be automatically installed with `xcodes` unless the `--without-aria2` flag is used. This also has the added advantage of marking `aria2` as a dependency of `xcodes`, so it will be listed with `brew leaves --installed-as-dependency` and it can be easily deleted if `xcodes` is deleted with `brew autoremove`. This closes RobotsAndPencils#4.
|
I created #4 to see if you considered this useful before making a Pull Request, but the change is so small that I think making the PR directly makes more sense. Also, please note that even if this is a small change, I don't know how to test Homebrew formulas. Maybe there's something wrong with this, or another change is needed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most users,
aria2is a vast improvement toxcodesusage, so I think it should be added as a recommended dependency toxcodeswhen installed using Homebrew, so it'll be automatically installed withxcodesunless the--without-aria2flag is used.This also has the added advantage of marking
aria2as a dependency ofxcodes, so it will be listed withbrew leaves --installed-as-dependencyand it can be easily deleted ifxcodesis deleted withbrew autoremove.This closes #4.