Skip to content

Commit

Permalink
Merge commit 'fab1eebe2c4c' into feature-bump-merge-curated-moar
Browse files Browse the repository at this point in the history
# Conflicts:
#	include/pybind11/eigen/matrix.h
  • Loading branch information
EricCousineau-TRI committed Oct 12, 2023
2 parents 432c941 + fab1eeb commit 098786d
Show file tree
Hide file tree
Showing 16 changed files with 1,235 additions and 13 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,4 @@ pybind11Targets.cmake
/pybind11/share/*
/docs/_build/*
.ipynb_checkpoints/
tests/main.cpp
2 changes: 2 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ set(PYBIND11_HEADERS
include/pybind11/complex.h
include/pybind11/options.h
include/pybind11/eigen.h
include/pybind11/eigen/matrix.h
include/pybind11/eigen/tensor.h
include/pybind11/embed.h
include/pybind11/eval.h
include/pybind11/gil.h
Expand Down
10 changes: 5 additions & 5 deletions include/pybind11/eigen/matrix.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
pybind11/eigen.h: Transparent conversion for dense and sparse Eigen matrices
pybind11/eigen/matrix.h: Transparent conversion for dense and sparse Eigen matrices
Copyright (c) 2016 Wenzel Jakob <[email protected]>
Expand All @@ -9,14 +9,14 @@

#pragma once

#include "../numpy.h"

// Similar to comments & pragma block in eigen_tensor.h. PLEASE KEEP IN SYNC.
/* HINT: To suppress warnings originating from the Eigen headers, use -isystem.
See also:
https://stackoverflow.com/questions/2579576/i-dir-vs-isystem-dir
https://stackoverflow.com/questions/1741816/isystem-for-ms-visual-studio-c-compiler
*/

#include "numpy.h"

// The C4127 suppression was introduced for Eigen 3.4.0. In theory we could
// make it version specific, or even remove it later, but considering that
// 1. C4127 is generally far more distracting than useful for modern template code, and
Expand Down Expand Up @@ -45,7 +45,7 @@
// move constructors that break things. We could detect this an explicitly copy, but an extra copy
// of matrices seems highly undesirable.
static_assert(EIGEN_VERSION_AT_LEAST(3, 2, 7),
"Eigen support in pybind11 requires Eigen >= 3.2.7");
"Eigen matrix support in pybind11 requires Eigen >= 3.2.7");

PYBIND11_NAMESPACE_BEGIN(PYBIND11_NAMESPACE)

Expand Down
Loading

0 comments on commit 098786d

Please sign in to comment.