Miscellaneous scrapping fixes #378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Python packages (e.g. launch_testing) have multiple entries in top_level.txt, with this commit they should be hanlded correctly.
When the workspace path has ~ characters (and possibly others), the JSON output by CMake will be a quoted string, e.g. ``` "lib": "\"/some/ws~~path/libfoo.so\"" ``` The extract path will be `"/some/ws~~path/libfoo.so"` instead of `/some/ws~~path/libfoo.so` and the former will not be treated as path down the line.
This is used in the domain_bridge package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello drake-ros maintainers,
Thank you for making this project available. We have been using it to build our software for the past months and we have built up a number of patches that we hope can be useful to everyone.
This PR is the first I'm opening and it contains 4 small patches related to various edge cases in the workspace scrapping that we have encountered.
Below is a short summary of the individual patches, I am happy to submit separate PRs if you prefer.
P1: Remove elements that have a condition attribute on ROS1
This is used by a number of packages that are trying to support both versions at the same time.
This patch is actually part of #336 we actually had our own patch that does pretty much the same thing (including packages that have the
$ROS_VERSION == 2condition instead of excluding the$ROS_VERSION == 1). However, that PR incorporates more changes this particular fix is not available on main yet so I hope it's ok to bring it in with this PR.P2: Fix an issue with some Python packages that have multiple entries in the egg
top_level.txt(seen in `launch_testing for example)P3: Fix an issue with CMake's JSON where libraries' paths are escaped under some conditions (for example if the workspace path has a
~character)P4: Include
*.incfiles in C++ headers of library, afaik, only thedomain_bridgepackage uses this extensionThanks again for making bazel_ros2_rules and I'm looking forward to your feedback.
This change is