Switch pub/sub serializers away from unique_ptr #374
Conversation
|
I ran an Anzu full local build+test against this patch and everything passed. +@EricCousineau-TRI for review, please. +@calderpg-tri for general approval or in case you'd like me/someone to do extra testing. |
There was a problem hiding this comment.
Some CI errors seem due to upstream breakages, other seems due to discrete\_contact\_solver, so related to #373.
I unfortunately don't have time atm to investigate, and don't want to hold progress on upstream issue.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @calderpg-tri)
jwnimmer-tri
force-pushed
the
shared-serializer
branch
from
1567abe to
6bbeae0
Compare
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:
Towards RobotLocomotion/drake#21968.
This contains the same kind of fixes as RobotLocomotion/drake#19369 and RobotLocomotion/drake#22463, plus one additional change (removing the apparently unnecessary
py::wrapper).This change is