-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple ROS Launch support. #287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're running a sample launch file, it'd be nice to add some nontrivial nodes and check that everything is working. Lets include a talker and listener demo if possible ?
I'd like to make sure all the environment variables are inherited and work together.
…es to talker/listeners.
Thanks for the tip; this uncovered issues I didn't catch with the previous log launches. It seems like there are some environment issues that I am not sure how to solve, since I don't thoroughly understand how the rules here work.
If I run
Guidance would be appreciated here. Although, now that I think about it, this is probably an issue with the python script we are running to run the launch files, not with any of the rules themselves. |
@tervay-bdai are you seeing the same error for both yaml and xml launch files ? |
Yes |
Another point to note is that the yaml and xml "frontends" to ros launch internally use the python launch style, so ideally if you support yaml/xml ros launch, the python style should work as well. |
Looks like we are missing python dependencies. I'm discussing how to add ros launch in a simpler way here : #214. Fixing the |
Closing since it seems like upstream is working on this and doing it better than I would. |
Addresses #214, as it's important for us.
This is a simple implementation of ROS launch support. It creates an executable Python script that parses the given launch file and calls
LaunchService().run()
with it.This does not support Python-based launch files, only XML and YAML, because I am not familiar enough with Python launch files to support that. (But would be happy to learn if pointed in the right direction.)
I am relatively new to custom Bazel rules/macros so there may be a better way you already had planned, and I'm happy to use that method if desired.
This change is