Skip to content

Commit

Permalink
Mac GHA: Remove workarounds that are no longer needed (#323)
Browse files Browse the repository at this point in the history
  • Loading branch information
BetsyMcPhail authored Oct 11, 2024
1 parent 396d03f commit 06eb38f
Showing 1 changed file with 0 additions and 32 deletions.
32 changes: 0 additions & 32 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,38 +34,6 @@ jobs:
# Remove the symlinks that cause issues.
find /usr/local/bin -lname '*/Library/Frameworks/Python.framework/*' -delete
sudo rm -rf /Library/Frameworks/Python.framework/
#
######################################################################
# For brew formulas that have issues during `brew upgrade` due to
# symlinks already existing, we use the strategy:
# brew list <formula> && (brew unlink ... )
# The `brew list <formula>` will error if it is not installed. When
# the logs say something like "No such keg: /some/path/<formula>"
# that means the band-aid can be removed from DEE CI.
######################################################################
# On 2023-02-24 `brew upgrade` resulted in a failure linking tcl-tk.
brew list tcl-tk && brew unlink tcl-tk
#
# On 2023-04-06 `brew upgrade` resulted in a failure upgrading `go`.
brew list go && ( \
brew unlink go && \
rm -f /usr/local/bin/go && \
rm -f /usr/local/bin/gofmt \
)
#
# On 2023-09-25 there were issues upgrading node@18 from 18.17.1 to
# 18.18.0, caused by `brew upgrade`.
brew list node@18 && ( \
brew unlink node@18 && \
rm -rf /usr/local/lib/node_modules/ \
)
######################################################################
# Run upgrades now to fail-fast (setup scripts do this anyway).
######################################################################
brew update && brew upgrade
# On 2023-02-16 the pip3.11 symlink was mysteriously missing.
brew unlink [email protected] && brew link [email protected]
pip3.11 --version
- name: setup
run: ./drake_cmake_installed/setup/mac/install_prereqs
shell: zsh -efuo pipefail {0}
Expand Down

0 comments on commit 06eb38f

Please sign in to comment.