Pass a relative path to PYTHON_INSTALL_DIR in ROS 2 #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing RoboStack/ros-humble#138, I noticed that we had a lot of patches due to the fact that in vinca we were passing
PYTHON_INSTALL_DIR
as an absolute path instead of a relative path, as it is required (see https://github.com/ament/ament_cmake/blob/2.3.2/ament_cmake_python/README.md#ament_get_python_install_dir).This PR modifies vinca to pass
PYTHON_INSTALL_DIR
as a relative path. Unfortunately, the existing patch in ros-humble are assuming thatPYTHON_INSTALL_DIR
is absolute, so merging this PR without also deleting those patch could create build failures.For the time being I just opened this PR to collect early feedback, but I am still testing it.