Be more verbose about commented-out packages in vinca files. #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #420, I tried adding a few lines explaining that commented-out packages are not a problem.
It would be worth also saying that not all commented-out packages will be uncommented during full rebuilds. I see some "marker lines" (like
PREVIOUSLY SUPPORTED PACKAGES) which probably denote packages that are no longer supported. But I don't know your workflow, so I'll let that one for you.Personally, I'd like if unsupported packages disappeared from the vinca files completely. It might also make sense to alphabetize the lists for easier orientation.