-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace Extension Functionality #36
Conversation
- Fixed recursion error for workspaces - Fixed workspace description typo in settings - Fixed viz-robotmodel.png not found
Workspace Extension Functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vkmb ,
thanks for your PR! Looks great, just needs some minor changes 😁
- Restored saved settings to default state - Fixed typo in settings schema - Removed unused import in Pkgs Module
Thanks a lot for the suggestions 👍 . I had fixed them in this ff46dff commit. |
This is awesome. Thanks for working on this PR @vkmb! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
By default, Zethus uses the
ROS_PACKAGE_PATH
set before Jupyter Hub launches.To use a new ROS workspace inside of Jupyter Lab, the existing procedure is,
This workflow is doable in a local instance. The problem arises with the Jupyter Hub instance launched from a Dockerfile.
In the Jupyter Hub instance with the current Jupyterlab-ros server plugin, it's impossible to add the new workspaces and fetch new robot models making it cumbersome to visualise robot models.
The updated plugin tries to solve this problem by enabling the user to add and delete workspaces as required for the task without restarting the Jupyter lab, copying the packages to the base path, modifying the Dockerfile and restarting Jupyter Hub instance.
To test the plugin