Workspace Extension Functionality #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed recursion error for workspaces - Fixed workspace description typo in settings - Fixed viz-robotmodel.png not found
Workspace Extension Functionality
IsabelParedes
requested changes
Sep 28, 2022
There was a problem hiding this comment.
Hi @vkmb ,
thanks for your PR! Looks great, just needs some minor changes 😁
- Restored saved settings to default state - Fixed typo in settings schema - Removed unused import in Pkgs Module
|
Thanks a lot for the suggestions 👍 . I had fixed them in this ff46dff commit. |
|
This is awesome. Thanks for working on this PR @vkmb! |
IsabelParedes
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Zethus uses the
ROS_PACKAGE_PATHset before Jupyter Hub launches.To use a new ROS workspace inside of Jupyter Lab, the existing procedure is,
This workflow is doable in a local instance. The problem arises with the Jupyter Hub instance launched from a Dockerfile.
In the Jupyter Hub instance with the current Jupyterlab-ros server plugin, it's impossible to add the new workspaces and fetch new robot models making it cumbersome to visualise robot models.
The updated plugin tries to solve this problem by enabling the user to add and delete workspaces as required for the task without restarting the Jupyter lab, copying the packages to the base path, modifying the Dockerfile and restarting Jupyter Hub instance.
To test the plugin