Skip to content

Conversation

@hbdc-BtcFixesThis
Copy link
Contributor

What does this PR do?

Fixes # #2234

This pr increases the maximum allowed escrow time from 8 to 10 hours

Checklist before merging

  • Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.

Copy link
Member

@KoalaSat KoalaSat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great you picked this one! Did you test the frontend? I think you will need some modifications on the Maker form

@hbdc-BtcFixesThis
Copy link
Contributor Author

Thanks @KoalaSat, I updated the maker form and searched the codebase for any other references escrow duration. I would gladly test the frontend but I think I may need some help with test data to fill out an order; or just advice on how to test the change. I'm not very familiar with the flow but the duration is likely set after the deposit. I'm not sure what ways you go about bypassing the step for local testing. Thanks in advanced!

Oh and I found a small grammar issue when I opened one of the files to update so I included as part of the pr; hope thats ok. I can split it out into a separate pr if that's helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants