Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone generation script #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BastiPaeltz
Copy link

This adds a standalone script so sourcing the plugin to zsh is not required, which saves loading time on shell startup.
Generating completions with the zsh-completion-generator is rather something you do once in a while and does not need to be sourced every time you start zsh in my opinion.
Also made the script a bit more verbose (help message, errors) and added support for custom help commands.

EDIT:
In addition one could add the following to the usage message to be super clear how to get the output into working zsh completions.

 zshgencomp ack > _ack
 mv _ack /usr/local/share/zsh/site-functions/

@RobSis
Copy link
Owner

RobSis commented Aug 20, 2015

Well, the plugin is running the python script only once, so I'm not sure how a big problem the loading time is. Is it that bad? Should we create ticket for a better performance?

Anyway, I don't like having two nearly identical scripts in the repo. Can the new script be used from the plugin? If yes, then lets drop the old one altogether...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants