Add support for Doctrine ORM v3 and Doctrine DBAL v4 #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slamdunk
added
enhancement
v-noskov
reviewed
Feb 7, 2024
example/full-config.php
Outdated
| @@ -77,14 +73,9 @@ | |||
| 'configuration' => 'orm_default', // Actually defaults to the entity manager config key, not hard-coded | |||
| ], | |||
| ], | |||
| 'event_manager' => [ | |||
| 'orm_default' => [ | |||
| 'subscribers' => [], | |||
There was a problem hiding this comment.
Doctrine ORM v.3 provides subscribing to events. Why are you going to drop support of the subscribers from the container?
There was a problem hiding this comment.
You are right, I've been deceived by the removal of EventManager support from the Connection.
I've restored it, and moved the key usage from doctrine.connection to doctrine.entity_manager.
|
Ok, I think we are good to go here. I've removed everything that's not supported anymore: if I missed something new, we can add it later in the next minor. 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.