Declare support for DBAL 3.8

Because the latest doctrine/orm, v3.2, supports DBAL "^3.8.2 || ^4", it would be nice to also support it here, as long as it not too much extra work.
Roave · Jul 10, 2024 · 5d10bff · 5d10bff
1 parent 3812ec5
commit 5d10bff
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/composer.json b/composer.json
@@ -18,7 +18,7 @@
     "require": {
         "php": "~8.2.0 || ~8.3.0",
         "doctrine/common": "^3.4.4",
-        "doctrine/dbal": "^4.0.4",
+        "doctrine/dbal": "^3.8.2 || ^4",
         "doctrine/event-manager": "^2.0.1",
         "doctrine/migrations": "^3.8.0",
         "doctrine/orm": "^3.2.1",

diff --git a/composer.lock b/composer.lock
diff --git a/test/ConfigurationFactoryTest.php b/test/ConfigurationFactoryTest.php
@@ -4,6 +4,8 @@
 
 namespace RoaveTest\PsrContainerDoctrine;
 
+use Composer\InstalledVersions;
+use Composer\Semver\VersionParser;
 use Doctrine\DBAL\Driver\Middleware;
 use Doctrine\ORM\Cache\CacheConfiguration;
 use Doctrine\ORM\Cache\DefaultCacheFactory;
@@ -211,7 +213,11 @@ public function testMistypeInSchemaAssetsFilterResolvedContainerId(): void
             );
 
         $this->expectException(TypeError::class);
-        $this->expectExceptionMessage('Doctrine\DBAL\Configuration::setSchemaAssetsFilter(): Argument #1 ($schemaAssetsFilter) must be of type callable, array given');
+        if (InstalledVersions::satisfies(new VersionParser(), 'doctrine/dbal', '^3.8')) {
+            $this->expectExceptionMessage('Doctrine\DBAL\Configuration::setSchemaAssetsFilter(): Argument #1 ($callable) must be of type ?callable, array given,');
+        } else {
+            $this->expectExceptionMessage('Doctrine\DBAL\Configuration::setSchemaAssetsFilter(): Argument #1 ($schemaAssetsFilter) must be of type callable, array given');
+        }
 
         (new ConfigurationFactory())($container);
     }