Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Renovate, drop PHP 7.4 support #162

Merged
merged 12 commits into from
Oct 31, 2022
Merged

Configure Renovate, drop PHP 7.4 support #162

merged 12 commits into from
Oct 31, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 31, 2022

Mend Renovate

Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.

🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.


Detected Package Files

  • composer.json (composer)
  • .github/workflows/coding-standards.yml (github-actions)
  • .github/workflows/mutation-tests.yml (github-actions)
  • .github/workflows/phpunit.yml (github-actions)
  • .github/workflows/psalm.yml (github-actions)
  • .github/workflows/release-on-milestone-closed.yml (github-actions)

Configuration

🔡 Renovate has detected a custom config for this PR. Feel free to ask for help if you have any doubts and would like it reviewed.

Important: Now that this branch is edited, Renovate can't rebase it from the base branch any more. If you make changes to the base branch that could impact this onboarding PR, please merge them manually.

What to Expect

With your current configuration, Renovate will create 5 Pull Requests:

Update all non-major dependencies
Update actions/cache action to v3
  • Schedule: ["at any time"]
  • Branch name: renovate/actions-cache-3.x
  • Merge into: 1.4.x
  • Upgrade actions/cache to v3
Update actions/checkout action to v3
  • Schedule: ["at any time"]
  • Branch name: renovate/actions-checkout-3.x
  • Merge into: 1.4.x
  • Upgrade actions/checkout to v3
Update dependency doctrine/coding-standard to v10
  • Schedule: ["at any time"]
  • Branch name: renovate/doctrine-coding-standard-10.x
  • Merge into: 1.4.x
  • Upgrade doctrine/coding-standard to ^10.0.0
Lock file maintenance
  • Schedule: ["before 2am"]
  • Branch name: renovate/lock-file-maintenance
  • Merge into: 1.4.x
  • Regenerate lock files to use latest dependency versions

❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.


Read more about the use of Renovate Bot within ocramius/* projects.

@Ocramius Ocramius added this to the 1.4.0 milestone Oct 31, 2022
@Ocramius Ocramius added enhancement New feature or request dependencies labels Oct 31, 2022
@Ocramius Ocramius self-assigned this Oct 31, 2022
@Ocramius Ocramius changed the title Configure Renovate Configure Renovate, drop PHP 7.4 support Oct 31, 2022
@Ocramius Ocramius added the help wanted Extra attention is needed label Oct 31, 2022
@Ocramius
Copy link
Member

PHPDBG seems to leak here: this is to be handled separately, in laminas/laminas-continuous-integration-action#130

@Ocramius Ocramius removed their assignment Oct 31, 2022
@Ocramius
Copy link
Member

Ok, fairly sure that mutation tests leak like crazy due to coverage report data collection 🤔

For example:

no-leaks on  renovate/configure via 🐘 v8.1.12 via ❄️  impure (nix-shell) 
❯ ./vendor/bin/phpunit --coverage-text
PHPUnit 9.5.26 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.12 with PCOV 1.0.11
Configuration: /home/ocramius/Documents/roave/no-leaks/phpunit.xml.dist
Random Seed:   1667250120

...................F.                                             21 / 21 (100%)

Time: 00:00.215, Memory: 16.00 MB

There was 1 failure:

1) RoaveUnitTest\NoLeaks\PHPUnit\EmptyBaselineMemoryUsageTest::testDoesNotProduceMemoryLeaks
Failed asserting that 12429784 is identical to 12427168.

/home/ocramius/Documents/roave/no-leaks/test/unit/EmptyBaselineMemoryUsageTest.php:27

FAILURES!
Tests: 21, Assertions: 27, Failures: 1.


Code Coverage Report:    
  2022-10-31 21:02:00    
                         
 Summary:                
  Classes: 75.00% (3/4)  
  Methods: 81.82% (9/11) 
  Lines:   96.61% (57/59)

Roave\NoLeaks\PHPUnit\CollectTestExecutionMemoryFootprints
  Methods:  50.00% ( 2/ 4)   Lines:  92.59% ( 25/ 27)
Roave\NoLeaks\PHPUnit\EmptyBaselineMemoryUsageTest
  Methods: 100.00% ( 1/ 1)   Lines: 100.00% (  1/  1)
Roave\NoLeaks\PHPUnit\MeasuredBaselineTestMemoryLeak
  Methods: 100.00% ( 3/ 3)   Lines: 100.00% ( 19/ 19)
Roave\NoLeaks\PHPUnit\MeasuredTestRunMemoryLeak
  Methods: 100.00% ( 3/ 3)   Lines: 100.00% ( 12/ 12)

@Ocramius Ocramius self-assigned this Oct 31, 2022
@Ocramius Ocramius removed the help wanted Extra attention is needed label Oct 31, 2022
@Ocramius Ocramius merged commit 02b452b into 1.4.x Oct 31, 2022
@Ocramius Ocramius deleted the renovate/configure branch October 31, 2022 21:08
sad270 added a commit to sad270/no-leaks that referenced this pull request Aug 2, 2023
Since Roave#162 we only support PHP 8.1 and PHP 8.2
This code added in Roave#124  is only for PHP 8.0 and PHP 7.4
sad270 added a commit to sad270/no-leaks that referenced this pull request Aug 2, 2023
Since Roave#162 we only support PHP 8.1 and PHP 8.2
This code added in Roave#124  is only for PHP 8.0 and PHP 7.4
sad270 added a commit to sad270/no-leaks that referenced this pull request Aug 2, 2023
Since Roave#162 we only support PHP 8.1 and PHP 8.2
This code added in Roave#124  is only for PHP 8.0 and PHP 7.4
sad270 added a commit to sad270/no-leaks that referenced this pull request Aug 2, 2023
Since Roave#162 we only support PHP 8.1 and PHP 8.2
This code added in Roave#124  is only for PHP 8.0 and PHP 7.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant