Skip to content

Commit

Permalink
Raise min phpcs version to 8.2
Browse files Browse the repository at this point in the history
  • Loading branch information
staabm committed Apr 21, 2024
1 parent 3a6f27b commit 6da6b4f
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion phpcs.xml.dist
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0"?>
<ruleset name="Roave/BetterReflection coding standard">
<config name="php_version" value="80100"/>
<config name="php_version" value="80200"/>
<arg value="p"/>
<arg value="s"/>
<arg name="colors"/>
Expand Down
1 change: 0 additions & 1 deletion src/Reflection/Adapter/ReflectionIntersectionType.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ public function __toString(): string
return $this->betterReflectionType->__toString();
}

/** @return false */
public function allowsNull(): bool

Check failure on line 38 in src/Reflection/Adapter/ReflectionIntersectionType.php

View workflow job for this annotation

GitHub Actions / Static Analysis by Psalm (locked, 8.3, ubuntu-latest)

InvalidReturnType

src/Reflection/Adapter/ReflectionIntersectionType.php:38:35: InvalidReturnType: The declared return type 'false' for Roave\BetterReflection\Reflection\Adapter\ReflectionIntersectionType::allowsNull is incorrect, got 'bool' (see https://psalm.dev/011)
{
return $this->betterReflectionType->allowsNull();

Check failure on line 40 in src/Reflection/Adapter/ReflectionIntersectionType.php

View workflow job for this annotation

GitHub Actions / Static Analysis by Psalm (locked, 8.3, ubuntu-latest)

InvalidReturnStatement

src/Reflection/Adapter/ReflectionIntersectionType.php:40:16: InvalidReturnStatement: The inferred type 'bool' does not match the declared return type 'false' for Roave\BetterReflection\Reflection\Adapter\ReflectionIntersectionType::allowsNull (see https://psalm.dev/128)
Expand Down
1 change: 0 additions & 1 deletion src/Reflection/ReflectionIntersectionType.php
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ public function getTypes(): array
return $this->types;
}

/** @return false */
public function allowsNull(): bool
{
return false;
Expand Down

0 comments on commit 6da6b4f

Please sign in to comment.