Skip to content

Commit

Permalink
rm activeSort from isMenuIconDirty for table
Browse files Browse the repository at this point in the history
  • Loading branch information
mdroidian committed Dec 13, 2023
1 parent dd85cb3 commit ee00835
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions src/components/ResultsView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -352,16 +352,20 @@ const ResultsView: ResultsViewComponent = ({
const [isEditColumnSort, setIsEditColumnSort] = useState(false);
const [isEditColumnFilter, setIsEditColumnFilter] = useState(false);
const [isEditSearchFilter, setIsEditSearchFilter] = useState(false);
const isMenuIconDirty = useMemo(
() =>
searchFilter || columnFilters.length || random.count || activeSort.length,
[searchFilter, columnFilters, random, activeSort]
);

const [layout, setLayout] = useState(settings.layout);
const layoutMode = useMemo(
() => (Array.isArray(layout.mode) ? layout.mode[0] : layout.mode),
[layout]
);
const isMenuIconDirty = useMemo(
() =>
searchFilter ||
columnFilters.length ||
random.count ||
(activeSort.length && layout.mode !== "table"), // indicator is on ResultHeader
[searchFilter, columnFilters, random, activeSort, layout.mode]
);
const onViewChange = (view: (typeof views)[number], i: number) => {
const newViews = views.map((v, j) => (i === j ? view : v));
setViews(newViews);
Expand Down

0 comments on commit ee00835

Please sign in to comment.