Fix BooruRipper 'URI is not absolute' error for gelbooru #2115 #2147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue
Fixes #2115 - BooruRipper was partially not working (xbooru works, gelbooru doesn't) due to a URISyntaxException when trying to create a URI from search terms.
Root Cause
The
getGID()method was trying to create a URI from search terms (like "animal_ears") usingnew URI(term).getPath(), which threwURISyntaxException: URI is not absolutebecause search terms are not valid absolute URIs.Solution
getGID()method to directly process the search term stringUtils.filesystemSafe()directly on the search termTesting
Test plan
testGetGID- passes for both gelbooru and xboorutestGetDomain- passes for both sitestestGetHost- passes for both sites🤖 Generated with Claude Code