Feature/dynamo state #49
Conversation
…te the table with new data
…the most recent config
…vel of dynamo state table
…fig version option
| @@ -40,6 +41,10 @@ def main(): | |||
| parser.add_argument("-D", "--debug", help="Sets logging level to DEBUG & enables traceback", action="store_true", dest="debug", default=False) | |||
| parser.add_argument("-v", "--version", help='Print version number', action='store_true', dest='version') | |||
| parser.add_argument("-T", "--timeout", type=int, help='Stack create timeout') | |||
| parser.add_argument("-O", "--export-yaml", help="Export stack config to specified YAML file.",default=None) | |||
| parser.add_argument("-o", "--export-json", help="Export stack config to specified JSON file.",default=None) | |||
| parser.add_argument("-i", "--config-version", help="Execute ( list | get | set ) of stack config.") | |||
There was a problem hiding this comment.
I feel like config-version isn't super clear that it is referring to a config action.
There was a problem hiding this comment.
I had previously agreed with you until I saw it used in the read me.
We could leave it as is, move these to -x, or make a new CLI utility.
I think moving to -x probably makes the most sense.
deployer -s some-stack-name -x config-list
@jasdbrown do you have any input on that? Do these flags cause a completely different operation? If I use -i with -x update what happens?
| if not args.all: | ||
| if not args.execute: | ||
| if args.config_version: | ||
| if args.config_version != "list" and args.config_version != "set" and args.config_version != "get": |
There was a problem hiding this comment.
I feel that if not args.config_version in ["list", "set", "get"]: might be more clear code. I'm guessing it's not as performant though.
…Networks/deployer into feature/dynamo-state
| **Note** | ||
| Network Class has been removed, it's irrelivant now. It was in place because of a work around in cloudformation limitations. The abstract class may not be relivant, all of the methods are simmular enough but starting this way provides flexablility if the need arise to model the class in a different way. | ||
| Network Class has been removed, it's irrelevant now. It was in place because of a work around in cloudformation limitations. The abstract class may not be relivant, all of the methods are simmular enough but starting this way provides flexablility if the need arise to model the class in a different way. |
There was a problem hiding this comment.
Lets remove this. Anyone that even recalls that is probably long gone.
|
|
||
| ``` | ||
| shared-deployer: | ||
| stack_name: shared-deployer |
There was a problem hiding this comment.
Maybe comment on this line like:
stack_name: shared-deployer # No longer required
| @@ -40,6 +41,10 @@ def main(): | |||
| parser.add_argument("-D", "--debug", help="Sets logging level to DEBUG & enables traceback", action="store_true", dest="debug", default=False) | |||
| parser.add_argument("-v", "--version", help='Print version number', action='store_true', dest='version') | |||
| parser.add_argument("-T", "--timeout", type=int, help='Stack create timeout') | |||
| parser.add_argument("-O", "--export-yaml", help="Export stack config to specified YAML file.",default=None) | |||
| parser.add_argument("-o", "--export-json", help="Export stack config to specified JSON file.",default=None) | |||
| parser.add_argument("-i", "--config-version", help="Execute ( list | get | set ) of stack config.") | |||
There was a problem hiding this comment.
I had previously agreed with you until I saw it used in the read me.
We could leave it as is, move these to -x, or make a new CLI utility.
I think moving to -x probably makes the most sense.
deployer -s some-stack-name -x config-list
@jasdbrown do you have any input on that? Do these flags cause a completely different operation? If I use -i with -x update what happens?
|
|
||
| class Config(object): | ||
| def __init__(self, file_name, master_stack): | ||
| def __init__(self, profile, stack_name, file_name=None, override_params=None): |
| #self.assertIn('update', [x['Value'] for x in tags if x['Key'] == 'Local']) | ||
| #self.assertIn('update', [x['Value'] for x in tags if x['Key'] == 'Override']) |
No description provided.