Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPi Intergration #37

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

PyPi Intergration #37

wants to merge 9 commits into from

Conversation

yeslayla
Copy link
Contributor

  • Renamed & Reconfigured Package
    The setup.py file was updated to use the package name semver-by-branch. The metadata was also updated to work with PyPi.
  • PIPELINE: Split Release Stage in Two
    The Release stage was split into the Release Packages stage and Push Docker Image stage. The Release Packages Stage pushes packages to GitHub & PyPi while the Push Docker Image stage pushes the latest tag to DockerHub.
  • DOCUMENTATION: Updates README.md
    The README.md file was updated to reflect installation using pip from PyPi.

Update to work with PyPI

Fix pipeline

Update pipeline

Update pipeline

Update pipeline
@yeslayla yeslayla requested a review from a team as a code owner January 20, 2020 17:49
@yeslayla yeslayla self-assigned this Jan 20, 2020
# Versions should comply with PEP440. For a discussion on single-sourcing
# the version across setup.py and the project code, see
# https://packaging.python.org/en/latest/single_source_version.html
name='semver-by-branch',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need to change the package name, that only has to be updated here.

Copy link

@dejonghe dejonghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good but the jenkins file doesnt look like it'll work, if it builds currently it may be because of prior builds having artifacts left around

Jenkinsfile Outdated Show resolved Hide resolved
Jenkinsfile Show resolved Hide resolved
Jenkinsfile Show resolved Hide resolved
Jenkinsfile Outdated Show resolved Hide resolved
PIPELINE: Use jenkin's docker library

PIPELINE: Use jenkin's docker library

PIPELINE: Use jenkin's docker library

PIPELINE: Use jenkin's docker library

PIPELINE: Use jenkin's docker library

PIPELINE: Use jenkin's docker library

PIPELINE: Use jenkin's docker library

PIPELINE: Use jenkin's docker library
sh "python setup.py sdist"

stash includes: "dist/semver-${env.SEMVER_NEW_VERSION}.tar.gz", name: 'PACKAGE'
script

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont need script here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required for dockerImage and docker.build

docker push rightbrainnetworks/auto-semver:${env.VERSION}
""")
sh("docker login -u ${DOCKER_USERNAME} -p ${DOCKER_PASSWORD}")
script

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont need script here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required for dockerImage object

Jenkinsfile Outdated Show resolved Hide resolved
@yeslayla
Copy link
Contributor Author

As a note, I tried removing the some of the script{}s in the Jenkinsfile, but they were required to use methods attached to use the docker.image and dockerImage objects.

@yeslayla yeslayla requested a review from dejonghe June 17, 2020 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants