-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Securely store the password using the keyring crate #46
base: master
Are you sure you want to change the base?
Conversation
NOTE: In order to compile on (Ubuntu) Linux, I had to install libdbus-1-dev. - Store a plain-text placeholder in config.json, with instructions on how to overwrite the stored password. - In case config.json contains a password value other than the placeholder, use that value, store it in the keyring at the end, and store the placeholder in config.json. - In case storing the password in keyring fails, store it in config.json as before.
The Linux build is failing because libdbus-1-3 is not installed (see https://github.com/diwic/dbus-rs#requirements); I'll see if I can google a solution to that one. |
- Broken by keyring’s requirement to have lidbdbus-1-3 installed on Linux.
With the latest commit, the build fails only on the raspberry pi, where |
WOW This one is awesome! |
Damn, there are conflicts! Can you please do the merge sacrifice ? |
ok, all this relies upon the presence of libdbus, as far as I understand. |
…eyring-password-store
Sadly, the linker still fails on raspberry pi with the message |
Can you add a |
NOTE: In order to compile on (Ubuntu) Linux, I had to install libdbus-1-dev.
Tested on macOS, Windows, Ubuntu Linux.
Store a plain-text placeholder in config.json, with instructions on how to
overwrite the stored password.
In case config.json contains a password value other than the placeholder,
use that value, store it in the keyring at the end, and store the placeholder
in config.json.
In case storing the password in keyring fails, store it in config.json as
before.