py3 friendly #5
Open
py3 friendly #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try/except in socks5 needed for timeout to not raise error `AttributeError: module 'socket' has no attribute '_socketobject'`
few tests still fails, if you can check them also would be great tests/test_config.py .....F..... [ 8%] tests/test_config_values.py .... [ 12%] tests/test_database.py ....F................................ [ 41%] tests/test_helpers.py .........FF....... [ 56%] tests/test_logs.py . [ 56%] tests/test_manager.py ............................ [ 79%] tests/test_misc.py ....... [ 84%] tests/test_socks5.py .........F.... [ 96%] tests/test_tools.py .....
|
@RicoVZ on appveyor it try to use |
|
the same for macos x but it builds just fine on linux |
Codecov Report
@@ Coverage Diff @@
## py3 #5 +/- ##
==========================================
- Coverage 71.74% 71.56% -0.18%
==========================================
Files 11 11
Lines 913 932 +19
==========================================
+ Hits 655 667 +12
- Misses 258 265 +7
Continue to review full report at Codecov.
|
Ubuntu 20.04 ubuntu-20.04 Ubuntu 18.04 ubuntu-latest or ubuntu-18.04
fixed sqlalchemy Dialect.has_table() error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.