Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing EUR format #68

Closed
wants to merge 2 commits into from
Closed

Fixing EUR format #68

wants to merge 2 commits into from

Conversation

nmaupu
Copy link

@nmaupu nmaupu commented Jun 27, 2020

Hi thanks for the lib !

This PR follows the issue #58 where a guy opens an issue and vanished...

I am not sure this is the official format for all EUR countries.
If this is not the case, I can create an EUR_FR for example (this the correct format for France for sure ;)).

@Rhymond
Copy link
Owner

Rhymond commented Oct 14, 2020

Hi @nmaupu
Thanks for the change

From the wiki (https://en.wikipedia.org/wiki/Euro_sign)

Placement of the sign also varies. Countries have generally continued the style used for their former currencies. In those countries where previous convention was to place the currency sign before the figure, the euro sign is placed in the same position (e.g., €3.50).[6] In those countries where the amount preceded the national currency sign, the euro sign is again placed in that relative position (e.g., 3,50 €).

It looks like there is no official rule on which side to place the sign, the whole table where to place the "eur" sign you can find here: https://en.wikipedia.org/wiki/Language_and_the_euro#Summary

Do you have any ideas how we can solve this? Do you think we should keep "1 $" because of the majority of countries have it?

@Rhymond
Copy link
Owner

Rhymond commented Apr 15, 2021

Please let me know if there are any updates and re-open the PR

@Rhymond Rhymond closed this Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants