Feature/polar sdk 5.16.0 #52
Conversation
|
This works on my Verity on iOS. The Verity connection is kind of fragile. If you want to switch which device it's connected to most of the time you have to power cycle the sensor. |
|
Yeah, the verity kinda sucks tbh. I just spent like an hour trying to figure out why it wasn't connecting and ended up having to spend 30 minutes factory resetting it and setting it up again. |
There was a problem hiding this comment.
These test files need updated for any added functionality:
example/integration_test/h10_test.dartexample/integration_test/verity_test.darttest/mock_test.dart
It would also be really helpful if you could create example/integration_test/360_test.dart to test functionality specific to the Polar 360, but that's not required to land this PR (but it will be required for the FTU PR)
| }, | ||
| ); | ||
| testSdkMode(identifier); | ||
| testMisc(identifier, isVerity: true); |
There was a problem hiding this comment.
| testMisc(identifier, isVerity: true); | |
| testMisc(identifier, supportsLedConfig: true); |
| ); | ||
| testStreaming( | ||
| identifier, | ||
| features: { |
There was a problem hiding this comment.
This should test all available streaming features. Is this everything the 360 supports? Does the 360 not support location?
| @@ -1,3 +1,5 @@ | |||
| import 'dart:ffi'; | |||
| @@ -1,5 +1,6 @@ | |||
| import 'dart:async'; | |||
| import 'dart:convert'; | |||
| import 'dart:ffi'; | |||
There was a problem hiding this comment.
What is this import for? This plugin shouldn't be using any FFIs.
|
This looks really close! Did you run the 360 test on both Android and iOS? I don't have a Polar 360 on hand so I cannot test it myself. |
Upgrades to polar sdk 5.16.0, and fixes issue introduced by that update.
This is working with my Polar Verity in Android, but not IOS. There are no errors, but it seems like my Verity is not attempting to pair to my iPhone.
Was hoping to get another set of eyes on this and see if that result is the same.