Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the upgrade-hybrid-common action #93

Merged
merged 16 commits into from
Jun 17, 2024
Merged

Adds the upgrade-hybrid-common action #93

merged 16 commits into from
Jun 17, 2024

Conversation

JayShortway
Copy link
Member

@JayShortway JayShortway commented Jun 14, 2024 •
edited
Loading

  • Adds the upgrade-hybrid-common action and accompanying workflow and job to the CircleCI config.
  • Adds the update_hybrid_common lane to Fastlane.
  • Also properly installs fastlane-plugin-revenuecat_internal.

Here's a successful (manual) run, and this is the PR it opened. (Which we're not merging because the base branch is not main.)

@JayShortway
Adds the Danger bot.
3a1907c
@JayShortway
Adds Gemfile.lock.
4b7041a
@JayShortway
Adds the fastlane gem.
7213ceb
@JayShortway
Adds an empty Fastfile, Pluginfile, and updates .gitignore.
4221a5e
@JayShortway
Merge branch 'refs/heads/main' into add-fastlane
50665fb 
# Conflicts:
#	Gemfile
#	Gemfile.lock
@JayShortway
Properly installs fastlane-plugin-revenuecat_internal.
c27365e
@JayShortway
Adds the update_hybrid_common lane.
d27eee3
@JayShortway
Adds the update-purchases-hybrid-common-version job.
3acae23
@JayShortway
Merge branch 'main' into add-upgrade-hybrid-common-action
da4a883 
# Conflicts:
#	Gemfile
#	Gemfile.lock
#	fastlane/Fastfile
@JayShortway
Adds the github-bot-public context.
ba14725
@JayShortway
Updates .gitignore.
d3ec7b5
@JayShortway
Removes the custom shell.
47ce25b
@JayShortway
Uses local clone of fastlane plugin. TODO revert!
da426c9
@JayShortway
Fixes some quotes.
6eabc07
@JayShortway
Fixes the update pattern?
eb5e38e
@JayShortway
Revert "Uses local clone of fastlane plugin. TODO revert!"
18a33f8 
This reverts commit da426c9.
@JayShortway JayShortway added the ci label Jun 14, 2024
@JayShortway JayShortway requested a review from a team June 14, 2024 16:35
@JayShortway JayShortway self-assigned this Jun 14, 2024
tonidero
tonidero approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fastlane/Fastfile Show resolved Hide resolved
@JayShortway JayShortway merged commit fd79599 into main Jun 17, 2024
6 checks passed
@JayShortway JayShortway deleted the add-upgrade-hybrid-common-action branch June 17, 2024 08:52
This was referenced Jun 17, 2024
Closed
Closed
@RCGitBot RCGitBot mentioned this pull request Jun 26, 2024
Merged
@RCGitBot RCGitBot mentioned this pull request Sep 4, 2024
Merged
@vegaro vegaro added pr:other and removed pr:ci labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonidero tonidero tonidero approved these changes

Assignees

@JayShortway JayShortway

Labels
pr:other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JayShortway @tonidero @vegaro