-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes the release pipeline #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some questions
release-tags-job: &release-tags-job | ||
filters: | ||
tags: | ||
only: /^[0-9]+\.[0-9]+\.[0-9]+(?!.*-SNAPSHOT).*$/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we tag snapshots right? I believe snapshots the way we do them in android/iOS is done automatically on every push to the main
branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I wonder if we should just copye the existing release-tags
alias in iOS/Android, where we basically ignore just some specific tags and release everything else... Mostly to be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't tag them indeed, but this was intended to be defensive against the potential case when we push a tag (e.g. for reference purposes) that we don't want to release. This matches all strings that start with a semver, with any suffix except "SNAPSHOT".
I'm okay to make it less strict to make it behave like iOS/Android, but I think it should still be a single regex for consistency with the workflow filter.
Fixes the release pipeline
Adds release tag filters to jobs as well.
As the title says. CircleCI is weird. This bug seems to have existed for a long time where workflows with a tag filter need to have the same filter on jobs as well.
One of many: https://discuss.circleci.com/t/running-a-workflow-after-tagging-commit/49581.
Without this change, we get a "No workflow" state from CircleCI.
After this change, the workflow runs.
Disables configuration cache for the publish task
This is not supported.