Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing API tests #106

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

JayShortway
Copy link
Contributor

@JayShortway JayShortway commented Jun 21, 2024

This adds a few API tests that were missing. KobanKat didn't have them at all at first, and later I added only the most important ones. We were discussing removing these API tests since we have the .api files. However this was a good exercise for me to go over the API one more time. 😄

The PR is quite big, but the commits are self contained. Here's a description for each commit to help reviewing. Happy to split the PR if needed!

1. c96d666

This one adds API tests for enums. A when over an expect enum cannot be made exhaustive in a common source set, because any platform might have more cases that the common source set doesn't know about. That's why the API tests for these enums are in both iosMain and androidMain, essentially duplicated. There's probably something smart we can do with placing them in a single folder and adding that folder to both iosMain and androidMain. However, since we were talking about maybe removing API tests altogether (since we have the .api files), I think this is fine for now.

2. 4ffe9f3

Some PurchasesConfiguration options were not API-tested yet. These are added here.

3. 9957ea4

SubscriptionOption did not have the presentedOfferingContext field. This commit adds that and removes the deprecated presentedOfferingId. Deprecated instead in eed2ae8.

4. abde9ef

This one adds Paywall API tests, as these didn't exist at all yet.

5. addfde4

This one adds the updated .api file. (Caused by 9957ea4 and eed2ae8).

@JayShortway JayShortway added breaking Changes that are breaking test Adding missing tests or correcting existing tests labels Jun 21, 2024
@JayShortway JayShortway requested a review from a team June 21, 2024 13:58
@JayShortway JayShortway self-assigned this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Changes that are breaking test Adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants