Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few API tests that were missing. KobanKat didn't have them at all at first, and later I added only the most important ones. We were discussing removing these API tests since we have the
.api
files. However this was a good exercise for me to go over the API one more time. 😄The PR is quite big, but the commits are self contained. Here's a description for each commit to help reviewing. Happy to split the PR if needed!
1. c96d666
This one adds API tests for enums. A
when
over anexpect enum
cannot be made exhaustive in a common source set, because any platform might have more cases that the common source set doesn't know about. That's why the API tests for these enums are in bothiosMain
andandroidMain
, essentially duplicated. There's probably something smart we can do with placing them in a single folder and adding that folder to bothiosMain
andandroidMain
. However, since we were talking about maybe removing API tests altogether (since we have the.api
files), I think this is fine for now.2. 4ffe9f3
Some PurchasesConfiguration options were not API-tested yet. These are added here.
3. 9957ea4
SubscriptionOption
did not have thepresentedOfferingContext
field. This commit adds that andremoves the deprecatedDeprecated instead in eed2ae8.presentedOfferingId
.4. abde9ef
This one adds Paywall API tests, as these didn't exist at all yet.
5. addfde4
This one adds the updated
.api
file. (Caused by 9957ea4 and eed2ae8).