fix(BaseDialog): remediate a close button bug on iOS Safari #4174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
approved these changes
Dec 1, 2025
Member
Jamiras
left a comment
Jamiras
left a comment
There was a problem hiding this comment.
Videos suggest problem has been fixed. Doesn't seem to break in my simulator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that only happens on iOS Safari.
When tapping a
BaseDialogclose button, Safari burrows the click through the button into whatever is behind it, which can trigger elements inadvertently. This is most especially prominent with global search and the user avatar dropdown menu.Unfortunately, this only reproduces on iOS Safari. I had to debug using the simulator on macOS. To smoke test, you shouldn't notice any regressions when using the close button in a React dialog.
The issue is fixed by temporarily placing a "shield" div between the dialog close button and whatever is underneath it. This stops the click event from burrowing through.
Before
Before.mp4
After
After.mp4