feat(multiset): add user subset preferences dialog to game pages #4157
Conversation
| return <SetSelectionTabs activeTab={activeTab} />; | ||
| return ( | ||
| <div className="flex w-full justify-between gap-2"> | ||
| <SetSelectionTabs activeTab={activeTab} /> |
There was a problem hiding this comment.
This seems to be broken. If I refresh a page, I can switch to/from the subset, but then I can't switch back until I refresh again.
There was a problem hiding this comment.
I still see this behavior.
2025-12-05.09-29-40.mp4
There was a problem hiding this comment.
Apologies, I misinterpreted this feedback.
This actually looks to be a bug in Inertia - some kind of race condition with our deferred prop. I've un-deferred the user prefs prop (it's a tiny piece of data anyway) and that seems to have fixed the issue.
...nButton/SubsetConfigurationDialogContent/SubsetConfigurationForm/SubsetConfigurationForm.tsx
Show resolved
Hide resolved
...setConfigurationButton/SubsetConfigurationDialogContent/SubsetConfigurationDialogContent.tsx
Show resolved
Hide resolved
| components={{ | ||
| 1: <a href={settingsUrl} target="_blank" />, | ||
| }} | ||
| /> |
There was a problem hiding this comment.
When globally opted out of all subsets (and no saved preferences), the core set appears unselected by default, but is correctly returned by the API (both by itself and with the subset if that is explicitly added).
There was a problem hiding this comment.
Adjusted this behavior in latest.
2 participants
This PR adds a "Subset Configuration" button and dialog to React game pages. The dialog allows users to manipulate their local opt in / opt out preferences for subsets.
The button conditionally renders when:
will_be_*type).If the user is globally opted in, toggles default to being enabled.
If the user is globally opted out, toggles default to being disabled.
User preferences are always respected regardless of global setting.
Brave.Browser.mp4