Checking for second unauthorized response after authorized registration fixes #18 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes RestComm#18 / endless registrations.
|
Thanks for opening the PR @sischnei ! Could you please take a quick look at our Open Source playbook, and make sure you have signed our Contributors License Agreement (from what I can see you haven't signed it before, have you?) |
|
@gsaslis I filled out the online form yesterday - anything else missing? |
|
Nope - thanks a lot @sischnei ! (and apologies for the late reply here... :) ) I can now pass this on to @RestComm/vvs-squad for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes endless registrations when invalid credentials are provided and the server responds with "401 Unauthorized" instead of "403 Forbidden".