Match typed arguments by type regardless of position#36
Open
alganet wants to merge 1 commit into
Open
Conversation
resolve() now binds typed parameters in a first pass: a positional object is claimed by the parameter declaring its type wherever it appears, so a leading untyped (scalar) parameter can no longer consume an object meant for a typed parameter declared after it. Untyped parameters then take the remaining positional arguments in declaration order. Add tests for out-of-order typed matching and update the README resolution order and a type-first example accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve() now binds typed parameters in a first pass: a positional object is claimed by the parameter declaring its type wherever it appears, so a leading untyped (scalar) parameter can no longer consume an object meant for a typed parameter declared after it. Untyped parameters then take the remaining positional arguments in declaration order.
Add tests for out-of-order typed matching and update the README resolution order and a type-first example accordingly.
This restores an old behavior with a small perf cost (two pass scan) that should be mild under a small number of arguments.
Tested with Config/Rest/Validation to ensure they still work cleanly.
This is a soft BC break (where before, an error would appear, now it might pass) but I would say anyone relying on that behavior was relying on unspecified behavior and therefore there's no actual BC break.