Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eip1559): use fork #929

Closed
wants to merge 3 commits into from
Closed

fix(eip1559): use fork #929

wants to merge 3 commits into from

Conversation

benjlevesque
Copy link
Contributor

See #765

@benjlevesque benjlevesque requested a review from yomarion October 5, 2022 10:42
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.256% when pulling 4ebb2cd on fix/eip1559/use-fork into 44dc374 on master.

@benjlevesque
Copy link
Contributor Author

This hack is unnecessary at the moment. Major providers accept int as parameters. The cleaner solution is still #765

@benjlevesque benjlevesque deleted the fix/eip1559/use-fork branch October 5, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-abrioux alexandre-abrioux alexandre-abrioux approved these changes

@KolevDarko KolevDarko KolevDarko approved these changes

@kevindavee kevindavee Awaiting requested review from kevindavee

@yomarion yomarion Awaiting requested review from yomarion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benjlevesque @coveralls @KolevDarko @alexandre-abrioux